Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyprland-activewindow: init at 1.0.1 #305404

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

kiike
Copy link
Member

@kiike kiike commented Apr 19, 2024

Description of changes

This package introduces a helper application for Hyprland users. It consists of a program that connects to the Hyprland IPC to monitor active window changes. Then, thanks to hyprland-activewindow's output, custom widgets such as waybar's or eww's can be updated with the current active window.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kiike kiike force-pushed the pkgs/hyprland-activewindow branch 3 times, most recently from 1c36cc4 to 6d9455f Compare April 19, 2024 23:32
@kiike kiike marked this pull request as draft April 20, 2024 14:47
@kiike kiike force-pushed the pkgs/hyprland-activewindow branch from 6d9455f to 1ae5f3b Compare April 20, 2024 14:48
@kiike kiike mentioned this pull request Apr 20, 2024
13 tasks
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to see more Hyprland in nixpkgs

pkgs/by-name/hy/hyprland-activewindow/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/hy/hyprland-activewindow/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/hy/hyprland-activewindow/package.nix Outdated Show resolved Hide resolved
@kiike
Copy link
Member Author

kiike commented Apr 20, 2024

Always nice to see more Hyprland in nixpkgs

Thanks for the review, @donovanglover! I learned a lot!

@kiike kiike marked this pull request as ready for review April 20, 2024 16:55
@kiike
Copy link
Member Author

kiike commented Apr 20, 2024

Would you like to co-maintain this, @donovanglover?

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Apr 20, 2024
@donovanglover
Copy link
Member

Sure

@donovanglover
Copy link
Member

LGTM after squashing to 1 commit "hyprland-activewindow: init at 1.0.1"

@kiike kiike force-pushed the pkgs/hyprland-activewindow branch from b17df2a to dfbcf4d Compare April 20, 2024 19:13
@kiike
Copy link
Member Author

kiike commented Apr 20, 2024

Squashed!

@Sigmanificient
Copy link
Member

Can you re-fetch master and rebase? Eval is failing and was fixed by #305609.

@kiike kiike marked this pull request as draft April 20, 2024 20:49
fix(hyprland-activewindow): resolve review issues

- avoid using repo = pname
- removal of period at end of description
- wrong homepage
- change platform to platforms.linux, since Hyprland is specific to Linux.

Co-authored-by: Donovan Glover <[email protected]>

Add donovanglover as co-maintainer
@kiike kiike force-pushed the pkgs/hyprland-activewindow branch from dfbcf4d to 72c2b8b Compare April 20, 2024 20:49
@kiike kiike marked this pull request as ready for review April 20, 2024 21:32
@donovanglover
Copy link
Member

Result of nixpkgs-review pr 305404 run on x86_64-linux 1

1 package built:
  • hyprland-activewindow

Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM however the "unknown event" messages could be fixed upstream

@kiike
Copy link
Member Author

kiike commented Apr 20, 2024

LGTM however the "unknown event" messages could be fixed upstream

Yes, there are some events that the hyprland crate is not yet ready to parse. They are in progress as per hyprland-community/hyprland-rs#177. But the program works fine for its purpose. Thanks for helping with this PR, @donovanglover!

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Apr 21, 2024
@Aleksanaa Aleksanaa merged commit ed0e28e into NixOS:master Apr 24, 2024
26 checks passed
@kiike
Copy link
Member Author

kiike commented Apr 24, 2024

Thanks for both merges @Aleksanaa!

@yavko
Copy link
Contributor

yavko commented May 3, 2024

LGTM however the "unknown event" messages could be fixed upstream

they can be disabled using the silent build flag

@kiike
Copy link
Member Author

kiike commented May 3, 2024

LGTM however the "unknown event" messages could be fixed upstream

they can be disabled using the silent build flag

I personally don't mind them. They might end up in a log that you won't see, or if you do see them, perhaps you get motivated enough to contribute to hyprland-activewindow or hyprland-rs. I personally am but I'm still a beginner in rust. Thanks for the tip, though, @yavko, and keep it up!

@kiike kiike deleted the pkgs/hyprland-activewindow branch May 9, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants