-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hyprland-activewindow: init at 1.0.1 #305404
Conversation
1c36cc4
to
6d9455f
Compare
6d9455f
to
1ae5f3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always nice to see more Hyprland in nixpkgs
Thanks for the review, @donovanglover! I learned a lot! |
Would you like to co-maintain this, @donovanglover? |
Sure |
LGTM after squashing to 1 commit "hyprland-activewindow: init at 1.0.1" |
b17df2a
to
dfbcf4d
Compare
Squashed! |
Can you re-fetch master and rebase? Eval is failing and was fixed by #305609. |
fix(hyprland-activewindow): resolve review issues - avoid using repo = pname - removal of period at end of description - wrong homepage - change platform to platforms.linux, since Hyprland is specific to Linux. Co-authored-by: Donovan Glover <[email protected]> Add donovanglover as co-maintainer
dfbcf4d
to
72c2b8b
Compare
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM however the "unknown event" messages could be fixed upstream
Yes, there are some events that the hyprland crate is not yet ready to parse. They are in progress as per hyprland-community/hyprland-rs#177. But the program works fine for its purpose. Thanks for helping with this PR, @donovanglover! |
Thanks for both merges @Aleksanaa! |
they can be disabled using the silent build flag |
I personally don't mind them. They might end up in a log that you won't see, or if you do see them, perhaps you get motivated enough to contribute to hyprland-activewindow or hyprland-rs. I personally am but I'm still a beginner in rust. Thanks for the tip, though, @yavko, and keep it up! |
Description of changes
This package introduces a helper application for Hyprland users. It consists of a program that connects to the Hyprland IPC to monitor active window changes. Then, thanks to
hyprland-activewindow
's output, custom widgets such as waybar's or eww's can be updated with the current active window.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.